Enable Ledger and filesystem APIs on GCC platform #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeuz
force-pushed
the
lfs_gcc/sc-125175
branch
2 times, most recently
from
3ea0054 to
a693ef4
Compare
sergeuz
changed the title
monkbroc
approved these changes
Feb 13, 2024
| @@ -259,9 +260,12 @@ int LedgerManager::init() { | |||
| if (!buf) { | |||
| return SYSTEM_ERROR_NO_MEMORY; | |||
| } | |||
| auto fsInstance = filesystem_get_instance(FILESYSTEM_INSTANCE_DEFAULT, nullptr); | |||
| assert(fsInstance); | |||
| FsLock fs(fsInstance); | |||
There was a problem hiding this comment.
Why does this one need to change but not the one in LedgerManager::getLedgerNames?
There was a problem hiding this comment.
The manager is expected to be initialized in getLedgerNames() and instance() will take care of that.
There was a problem hiding this comment.
Note that the main change in init() is that it now calls filesystem_mount() and the latter expects a filesystem_t instance, not lfs_t, hence the difference.
avtolstoy
approved these changes
Feb 19, 2024
| } | ||
|
|
||
| int hal_exflash_read(uintptr_t addr, uint8_t* data_buf, size_t data_size) { | ||
| try { |
There was a problem hiding this comment.
While this pattern is not used in normal Device OS sources for real devices, would be nice to introduce some CHECK-style macro or something along those lines to forward SYSTEM_ERROR_XXX error codes on exceptions to improve readability.
| static volatile bool initCalled = false; | ||
| if (!initCalled) { | ||
| static std::once_flag onceFlag; | ||
| std::call_once(onceFlag, []() { |
sergeuz
force-pushed
the
lfs_gcc/sc-125175
branch
from
a97c24b to
290a8ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds minimal implementations of
exflash_halandconcurrent_halfor the GCC platform, sufficient to support the LittleFS and Ledger APIs on that platform.By default, the contents of the external flash is stored in RAM and is not persistent, meaning that the virtual device will always start with an empty filesystem. The firmware executable can be provided with a
--flash_fileoption to enable persistent storage:In RAM and on disk, the contents of the external flash is stored in a sparse array to ensure that RAM and disk space are only allocated for the data actually in use by the firmware and we don't potentially spike the IO and RAM usage in load tests.