Fix msom usb + ble setup names #2753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eberseth
approved these changes
Mar 11, 2024
|
There is a few other places where this needs to be changed e.g. https://github.com/particle-iot/device-os/blob/develop/hal/src/b5som/app_usbd_string_config.h#L127. I'll take care of it before merging. |
avtolstoy
force-pushed
the
origin/fix/platform-product-series-names
branch
from
f5f67fb to
552749e
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Msom setup shows the wrong name: Mseries. It should be M-SoM
Same for P2 BLE setup and B-SoM.
Original by ScottBrust
Solution
Fix the hardcoded USB + BLE setup strings
Steps to Test
Build + flash branch. Setup msom on setup.particle.io, name should show as M SoM
Example App
tinker
References
Links to the Community, Docs, Other Issues, etc..
Completeness