Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resumable OTA fixes #2769

Merged
merged 2 commits into from
May 28, 2024
Merged

Resumable OTA fixes #2769

merged 2 commits into from
May 28, 2024

Conversation

sergeuz
Copy link
Member

@sergeuz sergeuz commented May 13, 2024 •
edited
Loading

Problem

  • DISCARD_DATA flag has no effect when it's set in a StartUpdate OTA request as opposed to FinishUpdate.
  • Cached module data isn't invalidated if the module validation failed.

References

  • sc-127555

@sergeuz sergeuz marked this pull request as ready for review May 14, 2024 14:51
@sergeuz sergeuz requested a review from avtolstoy May 14, 2024 14:51
@scott-brust scott-brust added this to the 5.8.2 milestone May 24, 2024
avtolstoy
avtolstoy approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@avtolstoy avtolstoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by manually triggering an error.

@scott-brust scott-brust force-pushed the discard-bad-resumed-ota/sc-127555 branch from 507424c to 210c58e Compare May 28, 2024 22:19
@scott-brust scott-brust merged commit 0e34f23 into develop May 28, 2024
13 checks passed
@scott-brust scott-brust deleted the discard-bad-resumed-ota/sc-127555 branch May 28, 2024 22:54
@scott-brust scott-brust mentioned this pull request Jun 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avtolstoy avtolstoy avtolstoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@sergeuz @avtolstoy @scott-brust