Improve delay() behavior #2828
Merged
Improve delay() behavior #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeuz
force-pushed
the
fix_delay/sc-130532
branch
from
305af33 to
4f9fd4b
Compare
technobly
approved these changes
Sep 19, 2024
avtolstoy
approved these changes
Sep 20, 2024
sergeuz
force-pushed
the
fix_delay/sc-130532
branch
from
8c30864 to
a5d1ef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR fixes a number of known problems with
delay()in threaded mode:delay()is not sub-tick precise.delay()causes to many context switches to the app thread when it's supposed to be suspended.Steps to Test
Run the
wiring/no_fixture_long_runningtest.