chore/eslint-update #107
chore/eslint-update #107
Conversation
| return Boolean(this.auth); | ||
| } | ||
|
|
||
| /** | ||
| * Get firmware library objects | ||
| * @param {Object} query The query parameters for libraries. See Particle.listLibraries | ||
| * @return {Promise} | ||
| * @returns {Promise} A promise |
There was a problem hiding this comment.
a bit silly since we should be specifying exactly what the promise is resolved & rejected with but it's enough to placate the linter and not any worse than what we were doing
| */ | ||
| downloadFirmwareBinary({ binaryId, auth, context }) { |
There was a problem hiding this comment.
wondering if this should be used here..? something like:
this.request({ uri, method: 'get', context });
| * emit 'event' events. | ||
| */ | ||
| getEventStream({ deviceId, name, org, product, auth, context }) { |
There was a problem hiding this comment.
another unused context instance - this one less controversial since i don't think it's relevant here?
| */ | ||
| createIntegration({ integrationType, event, settings, deviceId, product, auth, context }) { |
There was a problem hiding this comment.
another unused variable - flagging this one since the option was also documented
| */ | ||
| deleteLibrary({ name, version, force }) { |
There was a problem hiding this comment.
This makes me, hmmm
Undocumented argument, gets removed, doesn't cause any other changes in the diff unless I missed them, so maybe not a tested method. Just want to make sure this is alright?
There was a problem hiding this comment.
it's not being used so i think it's safe 👍
|
|
No description provided.