-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #110 #112
fixes #110 #112
Conversation
Hmm, now getting errors around "this.headers", these functions might have more issues than expected, looking into it. |
Okay, got downloadFirmwareBinary working, and made compatible changes to 'downloadProductFirmware', but I haven't tested that other call yet. |
Steps to Test: Here's the code I'm running for an internal testing tool, things you'll need:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, looks like you accidentally checked in package-lock.json
- you'll need to revert that before merging.
a66d500
to
cc9aa5d
Compare
okay, I think I removed the errant file, hopefully I didn't mess up the branch too bad |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - i'll get this merged and shipped ASAP 👍
cc9aa5d
to
06f2b2c
Compare
06f2b2c
to
2dd6a63
Compare
@dmiddlecamp apologies for the churn here - i had to tweak some stuff to accommodate testing given the current tooling, etc. do you mind trying these changes quick before i merge? |
checks the prefix which can otherwise be undefined, and would prevent these functions from working as expected.