-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [sc-123950] Update JSDocs for most functions #177
Merged
cole-abbeduto-particle
merged 10 commits into
master
from
feature/sc-123950/update-particle-api-js-with-ledger-apis
Dec 6, 2023
Merged
feat: [sc-123950] Update JSDocs for most functions #177
cole-abbeduto-particle
merged 10 commits into
master
from
feature/sc-123950/update-particle-api-js-with-ledger-apis
Dec 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-abbeduto-particle
changed the title
feat: [sc-123950] Update particle-api-js with Ledger APIs
feat: [sc-123950] Update JSDocs for most functions
Dec 5, 2023
laupow
reviewed
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of ideas in the comments, but generally it looks good to me.
CarlosHdez
approved these changes
Dec 5, 2023
monkbroc
approved these changes
Dec 5, 2023
cole-abbeduto-particle
deleted the
feature/sc-123950/update-particle-api-js-with-ledger-apis
branch
December 6, 2023 19:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/particle/story/123950
today_stats
query params to list logic functions APIscope
andarchived
filters along withpage
/per_page
query params to list ledgers APIpage
/per_page
query params to list ledger instances APItype | undefined
instead of marking as optional with[optionName]
query
JSDocs fromstring|object
toobject
since we only supportobject