Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setMode arg to setLedgerInstance #181

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Add setMode arg to setLedgerInstance #181

merged 2 commits into from
Jan 3, 2024

Conversation

cole-abbeduto-particle
Copy link
Contributor

  • Add support for query params in PUT request
  • Add setMode arg in setLedgerInstance which passes it as a query param

@cole-abbeduto-particle
Copy link
Contributor Author

Had to update a few random tests with query: undefined since they never expected to have a query passed through and were failing

@cole-abbeduto-particle cole-abbeduto-particle merged commit 3bc2e6a into master Jan 3, 2024
3 checks passed
@cole-abbeduto-particle cole-abbeduto-particle deleted the add-setLedgerInstance-setMode-query-arg branch January 3, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azenk azenk azenk approved these changes

@suda suda Awaiting requested review from suda

@laupow laupow Awaiting requested review from laupow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cole-abbeduto-particle @azenk