feat: [sc-126521] Report new account sign ups to Segment from API #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomontero
reviewed
Mar 25, 2024
| @@ -243,18 +243,20 @@ class Particle { | |||
| * @param {String} options.username Email of the new user | |||
| * @param {String} options.password Password | |||
| * @param {String} options.accountInfo Object that contains account information fields such as user real name, company name, business account flag etc | |||
| * @param {Object} [options.utm] Object that contains info about the campaign that lead to this user creation | |||
There was a problem hiding this comment.
I think it has an extra-space here.
monkbroc
deleted the
feature/sc-126521/report-new-account-sign-ups-to-segment-from
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/particle/story/126521
Allow passing UTM parameters from the login app to the API create user route