Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [sc-130912] Remove token delete/list APIs from particle-api-js #187

Conversation

cole-abbeduto-particle
Copy link
Contributor

Story details: https://app.shortcut.com/particle/story/130912

  • Remove support for basic auth from Agent
  • Remove deleteAccessToken and listAccessToken APIs
  • Remove tests that test the above removed features

Copy link

@hugomontero hugomontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good so far!
Regarding the headers should we add a message indicating that those headers are not supported anymore?

@cole-abbeduto-particle
Copy link
Contributor Author

@hugomontero It was only used by those two endpoints and it will be in the changelog with a major version bump. So people will know :)

@cole-abbeduto-particle cole-abbeduto-particle merged commit 13701e3 into master Sep 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants