Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to flash a product device with firmware #97

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

monkbroc
Copy link
Member

@monkbroc monkbroc commented Jan 10, 2019

I was writing a script to flash product devices and found that our API wrapper didn't support the product flash endpoint.

Manual test:

var Particle = require("particle-api-js");
var particle = new Particle();
var auth = "xyz";
var product = "8178";
var file = '/home/monkbroc/Downloads/bootloader-1.0.0-electron.bin';

particle.flashDevice({ deviceId: '123456', product, files: { file }, auth })
	.then(results => {
		console.log(results.body);
	});

@monkbroc monkbroc requested a review from samt January 10, 2019 15:57
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 74.177% when pulling 2dcc4eb on feature/flash-product into d8a27c2 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 74.177% when pulling 2dcc4eb on feature/flash-product into d8a27c2 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 74.177% when pulling 2dcc4eb on feature/flash-product into d8a27c2 on master.

Copy link

@JamesHagerman JamesHagerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@monkbroc monkbroc merged commit 1560afd into master Jan 10, 2019
@monkbroc monkbroc deleted the feature/flash-product branch January 10, 2019 18:10
@monkbroc monkbroc removed the request for review from samt January 10, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants