[RFC] [DML] INSERT, UPSERT, and REPLACE #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am357
force-pushed
the
main
branch
2 times, most recently
from
44ace81
to
c0c0041
Compare
hpolloni
reviewed
Jun 18, 2022
am357
force-pushed
the
main
branch
5 times, most recently
from
33d17d3
to
ce9da82
Compare
am357
force-pushed
the
main
branch
2 times, most recently
from
64b5189
to
40f8dc6
Compare
amrith
reviewed
Jun 21, 2022
amrith
reviewed
Jun 21, 2022
am357
force-pushed
the
main
branch
3 times, most recently
from
8b4dd98
to
1668d8a
Compare
am357
force-pushed
the
main
branch
3 times, most recently
from
cce7f79
to
745f7c9
Compare
am357
changed the title
dlurton
reviewed
Jul 21, 2022
am357
force-pushed
the
main
branch
3 times, most recently
from
39fcae0
to
09315bf
Compare
almann
reviewed
Aug 17, 2022
almann
previously approved these changes
Aug 18, 2022
am357
force-pushed
the
main
branch
4 times, most recently
from
89e7dd0
to
470cf94
Compare
- Replace double quotes w/ single quotes - Move DEFAULT for omitted attributes from MUST to MAY - Add a comment about addition of attribute - Add an example for closed -> open schema - Clarify referencing a missing value during on-conflict
amrith
approved these changes
Aug 26, 2022
almann
previously approved these changes
Aug 26, 2022
johnedquinn
reviewed
Jun 22, 2023
| ```EBNF | ||
| <insert statement> ::= INSERT INTO <table name> [ AS <alias> ] | ||
| [ ( <attr name> [, <attr name> ]... ) ] | ||
| <values> |
There was a problem hiding this comment.
Leaving a post-merge comment here: Since we use EXCLUDED as a variable name that references a value to be inserted, we could alternatively propose a follow-up RFC that specifies the syntax to allow an alias for the value to be inserted. Such as:
<insert statement> ::= INSERT INTO <table name> [ AS <alias> ]
[ ( <attr name> [, <attr name> ]... ) ]
<values> [ AS <alias> ]
...Note the [ AS <alias> ] after <values>
There was a problem hiding this comment.
@johnedquinn it's an intriguing idea: what do you consider the value it brings in addition to EXCLUDED?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #4
Description of changes:
This PR includes the RFC text for addition of PartiQL
INSERTandUPDATEspecification.rendered markdown file
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.