Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DatePart to DateTimePart at various places #409

Closed
abhikuhikar opened this issue May 14, 2021 · 1 comment
Closed

Rename DatePart to DateTimePart at various places #409

abhikuhikar opened this issue May 14, 2021 · 1 comment
Labels
S Small sized task technical debt

Comments

@abhikuhikar
Copy link
Contributor

Carefully rename DatePart to DateTimePart in LexerConstants.kt.
Make sure that all the associated usages such as variable names, comments, error messages, etc should also be renamed to DateTimePart as required and appropriate.
@alancai98 alancai98 added S Small sized task technical debt labels Jun 11, 2021
am357 added a commit that referenced this issue Jan 26, 2022
@am357
Rename DatePart to DateTimePart
feb0976 
As DatePart type includes Time components too, rename the type to
reflect the current value range.  In addition rename the related
functions.

GitHub Issue: #409
@am357 am357 mentioned this issue Jan 26, 2022
Merged
am357 added a commit that referenced this issue Jan 27, 2022
@am357
Rename DatePart to DateTimePart
27095cb 
As DatePart type includes Time components too, rename the type to
reflect the current value range.  In addition rename the related
functions.

GitHub Issue: #409
@am357
Copy link
Contributor

am357 commented Feb 3, 2022

This issue has been resolved, see the following for more details:
73c37e2

@am357 am357 closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S Small sized task technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@abhikuhikar @alancai98 @am357