Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORDER BY is dropped by three different VisitorTransforms #417

Closed
dlurton opened this issue Jun 14, 2021 · 0 comments · Fixed by #420
Closed

ORDER BY is dropped by three different VisitorTransforms #417

dlurton opened this issue Jun 14, 2021 · 0 comments · Fixed by #420

Comments

@dlurton
Copy link
Member

dlurton commented Jun 14, 2021 •
edited
Loading

If a user supplies an ORDER BY clause, it is simply ignored and they don't get an exception to tell them that the evaluator doesn't support ORDER BY.

ORDER BY is dropped here:

In addition to fixing each of these, to verify that we're not dropping ORDER BY anywhere else, we should add an EvaluatingCompilerTest that ensures an ErrorCode.EVALUATOR_FEATURE_NOT_SUPPORTED_YET is thrown.
This was referenced Jun 14, 2021
Closed
Open
dlurton added a commit that referenced this issue Jun 15, 2021
@dlurton
Prevent the ORDER BY clause from being dropped in visitor transforms
d0ece21 
Fixes #417

Which then prevents the EvaluationException from being thrown by
EvaluatingCompiler due to not having evaluation support for ORDER BY,
effectively ignoring the ORDER BY clause.
dlurton added a commit that referenced this issue Jun 15, 2021
@dlurton
Prevent the ORDER BY clause from being dropped in visitor transforms
935756c 
Fixes #417

Dropping the `ORDER BY` clause prevents the EvaluationException from
being thrown by EvaluatingCompiler due to not having evaluation
support for ORDER BY, effectively ignoring the ORDER BY clause.
dlurton added a commit that referenced this issue Jun 15, 2021
@dlurton
Prevent the ORDER BY clause from being dropped in visitor transforms
9ba2ebc 
Fixes #417

Dropping the ORDER BY clause prevents the EvaluationException from
being thrown by EvaluatingCompiler due to not having evaluation
support for ORDER BY, effectively ignoring the ORDER BY clause.
@dlurton dlurton mentioned this issue Jun 15, 2021
Merged
dlurton added a commit that referenced this issue Jun 15, 2021
@dlurton
Prevent the ORDER BY clause from being dropped in visitor transforms
2b672f6 
Fixes #417

Dropping the ORDER BY clause prevents the EvaluationException from
being thrown by EvaluatingCompiler due to not having evaluation
support for ORDER BY, effectively ignoring the ORDER BY clause.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent the ORDER BY clause from being dropped in visitor transforms partiql/partiql-lang-kotlin
1 participant
@dlurton