Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Being more straightforward on variables vs identifiers in the AST #1194

Closed
wants to merge 5 commits into from
Closed

Being more straightforward on variables vs identifiers in the AST #1194

wants to merge 5 commits into from

Commits on Aug 29, 2023

  1. Renamings in AST among identifier nodes. 

    In partiql.ion:
  id --> vr   [a case in (sum expr ...)]
  (product identifier name::symbol case::case_sensitivity)
  -->
  (product id         symb::symbol case::case_sensitivity)
    @vgapeyev
    vgapeyev committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    a53f366 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Reusing id within vr AST nodes in partiql.ion. 

    Or, in the generated AST, have an Id as a field of Expr.Vr,
instead of having Id's fields as fields of Expr.Vr as well.
    @vgapeyev
    vgapeyev committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    6bf7989 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Encapsulate uses of lowercase() that normalize a regular identifier. 

    By calling Ident.normalizeRegular() instead.
    @vgapeyev
    vgapeyev committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    c8915f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. CHANGELOG and a TODO on the oddity of #PathSimpleSymbol grammar rule.

    @vgapeyev
    vgapeyev committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    c31d6d6 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. An overlooked method rename: compileId --> compileVr.

    @vgapeyev
    vgapeyev committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    3d28210 View commit details
    Browse the repository at this point in the history