Add exclude physical plan compiler impl #1280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5384 Number failing in both: 434 Number passing in Base (ff60c72) but now fail: 0 Number failing in Base (ff60c72) but now pass: 0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## partiql-eval #1280 +/- ##
===============================================
Coverage ? 49.43%
Complexity ? 1047
===============================================
Files ? 166
Lines ? 13395
Branches ? 2502
===============================================
Hits ? 6622
Misses ? 6109
Partials ? 664
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alancai98
commented
Dec 5, 2023
partiql-eval/src/test/kotlin/org/partiql/lang/eval/EvaluatingCompilerExcludeTests.kt
Outdated
Show resolved
Hide resolved
partiql-eval/src/test/kotlin/org/partiql/lang/eval/EvaluatingCompilerExcludeTests.kt
Outdated
Show resolved
Hide resolved
partiql-eval/src/main/kotlin/org/partiql/lang/eval/internal/builtins/ScalarBuiltinsExt.kt
Show resolved
Hide resolved
alancai98
force-pushed
the
partiql-eval
branch
from
ec4a767
to
0f053b6
Compare
alancai98
added a commit
that referenced
this pull request
Dec 6, 2023
subsumption tests (to be added back in #1280)
alancai98
force-pushed
the
add-exclude-physical-plan-compiler-impl
branch
from
7a1b73f
to
c911b86
Compare
alancai98
force-pushed
the
partiql-eval
branch
from
0f053b6
to
ec4a767
Compare
alancai98
added a commit
that referenced
this pull request
Dec 7, 2023
- comment out subsumption tests (to be added in #1280)
alancai98
force-pushed
the
partiql-eval
branch
from
ec4a767
to
4ac1b3d
Compare
alancai98
force-pushed
the
add-exclude-physical-plan-compiler-impl
branch
3 times, most recently
from
665ba54
to
0b46b02
Compare
RCHowell
pushed a commit
that referenced
this pull request
Dec 8, 2023
- comment out subsumption tests (to be added in #1280)
alancai98
force-pushed
the
add-exclude-physical-plan-compiler-impl
branch
from
bba80b4
to
c526f37
Compare
alancai98
commented
Dec 12, 2023
| @@ -117,33 +111,6 @@ class EvaluatingCompilerExcludeTests : EvaluatorTestBase() { | |||
| } | |||
| >>""" | |||
| ), | |||
| EvaluatorTestCase( // EXCLUDE select star with FROM source list | |||
There was a problem hiding this comment.
Test was same as above.
| tc, | ||
| EvaluationSession.standard() | ||
| ) | ||
| // TODO: subsumption tests to be added back in https://github.com/partiql/partiql-lang-kotlin/pull/1280 |
There was a problem hiding this comment.
Subsumption tests moved to partiql-eval/src/test/kotlin/org/partiql/lang/eval/internal/exclude/CompiledExcludeExprTest.kt
| * If possible, prefer the use of the other methods instead because they might return [ExprValue] instances | ||
| * that are better optimized for their specific data type (depending on implementation). | ||
| */ | ||
| internal fun ionValueToExprValue(value: IonValue): ExprValue { |
There was a problem hiding this comment.
Ported from ExprValue.kt and renamed from ExprValue.of(value) to ionValueToExprValue(value)
| import org.partiql.lang.eval.OrdinalBindings | ||
| import org.partiql.lang.eval.internal.ext.namedValue | ||
|
|
||
| internal class ListExprValue(val values: Sequence<ExprValue>) : BaseExprValue() { |
There was a problem hiding this comment.
These sequence ExprValues were ported from ExprValue.kt. They were internal to partiql-lang. Needed to case on the concrete Java class name in ExcludeRelationalOperatorFactory, so ported to this file in partiql-eval.
alancai98
changed the title
alancai98
added a commit
that referenced
this pull request
Dec 12, 2023
- comment out subsumption tests (to be added in #1280)
- Port over List/Bag/Sexp ExprValue to partiql-eval - Port over IonValue to ExprValue conversion to partiql-eval - Change PhysicalPlanCompilerImpl (and other partiql-eval) to use internal partiql-eval apis
alancai98
force-pushed
the
add-exclude-physical-plan-compiler-impl
branch
from
c526f37
to
c2ea303
Compare
|
Will close this PR in favor of adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
EXCLUDESELECT * EXCEPT/EXCLUDE partiql-lang#27Description
Adds implementation of
EXCLUDEto the plan compiler (different from #1249, which addsEXCLUDEto theEvaluatingCompiler). This PR also migrates more of thepartiql-langAPIs topartiql-eval'sinternalpackage.Other Information
Updated Unreleased Section in CHANGELOG: [YES]
Any backward-incompatible changes? [NO]
Any new external dependencies? [NO]
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES]
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.