Fix #228 by removing invalid sanity check. #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sanity check threw an exception from SqlParser whenever a data type reference that included more than one argument was encountered. The check appears to have been completely erroneous from the start and on removivng it, no other modifications were needed. This commit also adds a few tests to SqlParserTests to cover this scenario and prevent regressions.
therapon
reviewed
Mar 24, 2020
therapon
approved these changes
Mar 24, 2020
dlurton
added a commit
that referenced
this pull request
Mar 25, 2020
This sanity check threw an exception from SqlParser whenever a data type reference that included more than one argument was encountered. The check appears to have been completely erroneous from the start and on removing it, no other modifications were needed. However, note that at this time we do not actually do anything with those arguments. At this time their presence is simply tolerated to improve SQL-92 compatibility. See #231 for one way we could use these arguments. This commit also adds a few tests to SqlParserTests to cover this scenario and prevent regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228
This sanity check threw an exception from SqlParser whenever a data type reference that included more than one argument was encountered. The check appears to have been completely erroneous from the start and on removivng it, no other modifications were needed.
This commit also adds a few tests to SqlParserTests to cover this scenario and prevent regressions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.