Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect ProjectionIterationBehavior.UNFILTERED within star projection #247

Merged
merged 1 commit into from
May 19, 2020

Conversation

dlurton
Copy link
Member

@dlurton dlurton commented May 18, 2020

Fixes #246

We previously ignored this compile option. The fix prevents the filtering of MISSING values from star projection when ProjectionIterationBehavior.UNFILTERED is set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dlurton dlurton requested a review from therapon May 18, 2020 23:55
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #247 into master will decrease coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #247      +/-   ##
============================================
- Coverage     84.35%   84.01%   -0.34%     
- Complexity     1068     1225     +157     
============================================
  Files           127      155      +28     
  Lines          8927     9616     +689     
  Branches       1478     1594     +116     
============================================
+ Hits           7530     8079     +549     
- Misses          940     1048     +108     
- Partials        457      489      +32     
Flag Coverage Δ Complexity Δ
#CLI 53.92% <ø> (ø) 44.00 <ø> (ø)
#EXAMPLES 75.34% <ø> (ø) 27.00 <ø> (ø)
#LANG 85.68% <ø> (ø) 997.00 <ø> (ø)
#PTS 100.00% <ø> (ø) 0.00 <ø> (ø)
#TEST_SCRIPT 79.68% <ø> (?) 157.00 <ø> (?)
Impacted Files Coverage Δ Complexity Δ
...ng/src/org/partiql/lang/eval/EvaluatingCompiler.kt 83.48% <ø> (ø) 150.00 <0.00> (ø)
...script/src/org/partiql/testscript/parser/Parser.kt 89.65% <0.00%> (ø) 29.00% <0.00%> (?%)
...pt/src/org/partiql/testscript/compiler/Compiler.kt 87.25% <0.00%> (ø) 23.00% <0.00%> (?%)
.../org/partiql/testscript/compiler/CompilerErrors.kt 100.00% <0.00%> (ø) 3.00% <0.00%> (?%)
...tiql/testscript/parser/ast/builders/TestBuilder.kt 90.00% <0.00%> (ø) 12.00% <0.00%> (?%)
...artiql/testscript/compiler/TestScriptExpression.kt 41.17% <0.00%> (ø) 0.00% <0.00%> (?%)
...estscript/parser/ast/builders/AppendTestBuilder.kt 100.00% <0.00%> (ø) 3.00% <0.00%> (?%)
...rc/org/partiql/testscript/parser/ScriptLocation.kt 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
...rc/org/partiql/testscript/evaluator/Evaluator.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...tscript/src/org/partiql/testscript/PtsException.kt 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd85ee6...c42f9b8. Read the comment docs.

@dlurton dlurton merged commit c1ed67e into master May 19, 2020
@dlurton dlurton deleted the fix-246 branch May 19, 2020 18:39
therapon added a commit that referenced this pull request Jun 9, 2020
* Respect ProjectionIterationBehavior.UNFILTERED within star projection (#247)

Fixes #246

* Prepare release 0.2.1

Co-authored-by: David Lurton <dlurton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Star projection fails to respect ProjectionIterationBehavior.UNFILTERED
3 participants