Fix bug causing multiple nested nots to parse very slowly
#436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors `SqlParser.parseUnaryTerm` so it does not attempt to needlessly re-parse every sub-expression of the `not` unary operator. This effect was cumulative, so that multiple nestings of `not` would become pathologically slow.
alancai98
approved these changes
Sep 9, 2021
Codecov Report
@@ Coverage Diff @@
## main #436 +/- ##
============================================
- Coverage 82.33% 82.31% -0.03%
+ Complexity 1396 1394 -2
============================================
Files 171 171
Lines 10724 10723 -1
Branches 1768 1769 +1
============================================
- Hits 8830 8827 -3
Misses 1353 1353
- Partials 541 543 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alancai98
pushed a commit
that referenced
this pull request
Sep 13, 2021
Refactors `SqlParser.parseUnaryTerm` so it does not attempt to needlessly re-parse every sub-expression of the `not` unary operator. This effect was cumulative, so that multiple nestings of `not` would become pathologically slow. (cherry picked from commit 6de9ca0)
alancai98
pushed a commit
that referenced
this pull request
Sep 13, 2021
Refactors `SqlParser.parseUnaryTerm` so it does not attempt to needlessly re-parse every sub-expression of the `not` unary operator. This effect was cumulative, so that multiple nestings of `not` would become pathologically slow. (cherry picked from commit 6de9ca0)
alancai98
added a commit
that referenced
this pull request
Sep 13, 2021
) Refactors `SqlParser.parseUnaryTerm` so it does not attempt to needlessly re-parse every sub-expression of the `not` unary operator. This effect was cumulative, so that multiple nestings of `not` would become pathologically slow. (cherry picked from commit 6de9ca0)
alancai98
added a commit
that referenced
this pull request
Sep 13, 2021
) Refactors `SqlParser.parseUnaryTerm` so it does not attempt to needlessly re-parse every sub-expression of the `not` unary operator. This effect was cumulative, so that multiple nestings of `not` would become pathologically slow. (cherry picked from commit 6de9ca0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors
SqlParser.parseUnaryTermso it does not attempt toneedlessly re-parse every sub-expression of the
notunary operator.This effect was cumulative, so that multiple nestings of
notwouldbecome pathologically slow.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.