Fixes group by for more than 2 nested path expressions. #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
=========================================
Coverage 82.38% 82.39%
Complexity 1407 1407
=========================================
Files 171 171
Lines 10817 10816 -1
Branches 1783 1782 -1
=========================================
Hits 8912 8912
Misses 1360 1360
+ Partials 545 544 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
jpschorr
reviewed
Oct 26, 2021
lang/test/org/partiql/lang/eval/EvaluatingCompilerGroupByTest.kt
Outdated
Show resolved
Hide resolved
jpschorr
reviewed
Oct 26, 2021
lang/src/org/partiql/lang/eval/visitors/GroupByPathExpressionVisitorTransform.kt
Show resolved
Hide resolved
alancai98
approved these changes
Oct 27, 2021
jpschorr
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #458
Description of changes:
Removes check for
component's step.size != 1inGroupByPathExpressionVisitorTransform.kt.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.