-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug on CLI output IONTEXT to file #479
Conversation
Codecov Report
@@ Coverage Diff @@
## main #479 +/- ##
=========================================
Coverage 82.38% 82.38%
Complexity 1406 1406
=========================================
Files 171 171
Lines 10816 10817 +1
Branches 1781 1781
=========================================
+ Hits 8911 8912 +1
Misses 1361 1361
Partials 544 544
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks reasonable to me. However, after executing partiql -q "1" --output-format ION_TEXT -o temp.ion
, it still waits to read from stdin
but does not throw a stream closed
error after providing input to stdin
as it used to. However, I believe this should not be the case. The command should not wait for the input from stdin
.
I think this issue is resolved in another PR, #478 |
Issue #473
Problem Description
As show in https://github.com/partiql/partiql-lang-kotlin/blob/main/cli/src/org/partiql/cli/Cli.kt#L52-53, the
use
block in L52 invokesclose()
function onoutput
. In case ofFileOutputStream
, it indeed closes the output stream. Thus, thewrite()
function in L53 throws an exception.Description of changes:
use
block.