Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] remove wildcard imports #483

Merged
merged 3 commits into from
Dec 21, 2021
Merged

[cli] remove wildcard imports #483

merged 3 commits into from
Dec 21, 2021

Conversation

am357
Copy link
Contributor

@am357 am357 commented Dec 20, 2021

Issue #, if available: 481

Description of changes: Included the following changes:

  1. Adds macOs coverage in cli's .gitignore.
  2. Removes the redundant lines in build.gradle.
  3. To increase the code readability, replaces the wildcard imports with explicit imports in cli package.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Arash M added 3 commits December 20, 2021 11:33
Remove redundant lines
- Include macOs coverage
- New idea files
- Other misc. inclusions
Replace the wildcard imports with explicit ones to make the code easier to read.
@am357 am357 self-assigned this Dec 20, 2021
@am357 am357 added CLI PartiQL CLI specific technical debt labels Dec 20, 2021
@am357 am357 linked an issue Dec 20, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2021

Codecov Report

Merging #483 (95414fd) into main (06b4ee1) will increase coverage by 0.00%.
The diff coverage is 17.24%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #483   +/-   ##
=========================================
  Coverage     82.44%   82.44%           
  Complexity     1330     1330           
=========================================
  Files           171      171           
  Lines         10906    10907    +1     
  Branches       1785     1785           
=========================================
+ Hits           8991     8992    +1     
  Misses         1368     1368           
  Partials        547      547           
Flag Coverage Δ
CLI 20.86% <17.24%> (+0.26%) ⬆️
EXAMPLES 75.14% <ø> (ø)
LANG 84.84% <ø> (ø)
PTS ∅ <ø> (∅)
TEST_SCRIPT 79.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/src/org/partiql/cli/Repl.kt 0.00% <0.00%> (ø)
cli/src/org/partiql/cli/Runnable.kt 0.00% <ø> (ø)
cli/src/org/partiql/cli/functions/BaseFunction.kt 55.55% <ø> (ø)
cli/src/org/partiql/cli/functions/ReadFile.kt 77.27% <ø> (ø)
cli/src/org/partiql/cli/functions/WriteFile.kt 64.51% <ø> (ø)
cli/src/org/partiql/cli/main.kt 0.00% <ø> (ø)
cli/src/org/partiql/cli/stopwatch.kt 0.00% <ø> (ø)
cli/src/org/partiql/cli/streams.kt 50.00% <ø> (ø)
cli/src/org/partiql/cli/Cli.kt 90.47% <83.33%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06b4ee1...95414fd. Read the comment docs.

Copy link
Member

@alancai98 alancai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@am357 am357 merged commit 58f5edb into main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI PartiQL CLI specific technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cli] [source-code] remove wildcard imports
3 participants