CAST: Improve the CAST assertion assertEval #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve the CAST assertion assertEval with removing a redundant assertion for permissive mode since we already run tests for this mode as part of the overall process. Issue #, if available: 519 Description of changes: Parameterize the error message.
Codecov Report
@@ Coverage Diff @@
## main #523 +/- ##
=========================================
Coverage 80.91% 80.91%
Complexity 1687 1687
=========================================
Files 196 196
Lines 14305 14305
Branches 2944 2944
=========================================
Hits 11575 11575
Misses 1776 1776
Partials 954 954
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the CAST assertion assertEval with removing a redundant
assertion for permissive mode since we already run tests for this
mode as part of the overall process.
Issue #, if available: 519
Addressed the comment from the original PR which was closed because it was having changes from
remove-unused-importschange:#520
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.