Clean up ExprFunction test #529
Conversation
Codecov Report
@@ Coverage Diff @@
## main #529 +/- ##
============================================
- Coverage 80.91% 80.72% -0.20%
+ Complexity 1687 1681 -6
============================================
Files 196 196
Lines 14305 14307 +2
Branches 2944 2944
============================================
- Hits 11575 11549 -26
- Misses 1776 1798 +22
- Partials 954 960 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
. Can you also add a more detailed PR description?| @@ -441,7 +441,7 @@ class SqlParser( | |||
| else -> errMalformedParseTree("Unsupported path component: ${it.type}") | |||
| } | |||
| } | |||
| path(rootExpr, pathComponents, metas) | |||
| path(rootExpr, pathComponents, rootExpr.metas) // Here we use its root source location, since itself has no source location (not a token). | |||
There was a problem hiding this comment.
nit: for future PRs, it would be helpful to start with a clean commit history (i.e. not including commits from other PRs). GitHub shows this as a changed file even though your target branch, main, already has this change, which can be confusing for the reviewer.
You could start by creating the branch directly off of main:
git checkout main
git pull
git checkout feature-branch
... (make and commit changes) ...
... (create PR with feature-branch) ...
If the origin GitHub branch already has the commits, you can rebase and force push to the origin branch.
Description of Changes
ExprFunctiontest, used one parameterized test to cover all pass test cases.ExprFunctiontest, used one parameterized test to cover all invalid arguments test cases.InvalidArgTypeCheckerto automatically generate invalid argument type test cases for eachExprFunction.InvalidArityCheckerto automatically generate invalid arity test cases for eachExprFunction.The first 4 commits are not relevant.