Fix all compiler warnings #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alancai98
approved these changes
Apr 4, 2022
Thanks for fixing all the warnings! Left one non-blocking question out of curiosity| @@ -50,7 +53,6 @@ import kotlin.test.assertEquals | |||
| * | |||
| * As we parameterize PartiQL's other tests, we should migrate them away from using this base class as well. | |||
| */ | |||
| @Deprecated("This class and everything in it should be considered deprecated.") | |||
There was a problem hiding this comment.
Always wondered about why EvaluatorTestBase was deprecated. Any insight into its history?
There was a problem hiding this comment.
The intention was to migrate to the new test DSL that I made. That migration however never happened and the deprecation was just causing a ton of compiler warnings.
|
Since this PR resolves all the current warnings, may want to also enable future warnings as errors #256. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been doing some extensive work on this code base lately and the compiler warnings (which numbered ~900, IIRC) were driving me crazy since I couldn't tell if I was adding new warnings or not, so I decided to knock this out this morning. It took only about 1.5 hours since most of them were related to
ExprNodedeprecation.In the future, it will be easy to tell if there are new warnings or not and we should consider a way of enforcing this.
This addresses #541 and all other warnings as well.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.