Migrate to PIG 0.5.0 #563
Merged
Migrate to PIG 0.5.0 #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlurton
commented
Apr 4, 2022
| @@ -91,4 +90,4 @@ open class PartiQLBenchmark { | |||
| val exprValue = state.expression.eval(state.session) | |||
| blackhole.consume(exprValue) | |||
| } | |||
| } | |||
There was a problem hiding this comment.
Not sure what's going on here but for some odd reason ktlint decided it no longer liked the lack of newline here in my local build. Not sure why it was ok with it previously...
alancai98
reviewed
Apr 5, 2022
| } | ||
| } | ||
|
|
||
| def partiqlDomainFile = 'partiql-domains.kt' |
There was a problem hiding this comment.
Could the .gitignore in the lang/domains folder also be deleted in this PR?
alancai98
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates to the most recent version of PIG. PIG now puts each domain into its own output files instead of one uber
partiql-domains.ktfile, which until this PR, took a ton of memory to compile and made IntelliJ's code completion choke with only 3-4 domains permuted frompartiql_ast.This modifies the gradle build such that:
0.5.0instead of0.4.0.lang/build/generated/src/pig(instead oflang/domains)partiql-domains.ktfile is deleted automatically (to avoid having to remember to do this manually after working with an older revision of this repo).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.