Codecov: Failed to properly upload: The process '/home/runner/work/_actions/codecov/codecov-action/v3/dist/codecov' failed with exit code 255

warning: this expression creates a reference which is immediately dereferenced by the compiler --> partiql-logical-planner/src/typer.rs:274:18 | 274 | _ => &ty, | ^^^ help: change this to: `ty` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: deref which would be done by auto-deref --> partiql-logical-planner/src/typer.rs:186:33 | 186 | self.type_vexpr(*&v, LookupOrder::LocalGlobal); | ^^^ help: try this: `&v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default

warning: redundant clone --> partiql-logical-planner/src/typer.rs:223:76 | 223 | let new_type_env = IndexMap::from([(string_to_sym("_1"), ty.clone())]); | ^^^^^^^^ help: remove this | note: this value is dropped without further use --> partiql-logical-planner/src/typer.rs:223:74 | 223 | let new_type_env = IndexMap::from([(string_to_sym("_1"), ty.clone())]); | ^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

warning: redundant clone --> partiql-logical-planner/src/typer.rs:160:36 | 160 | ... sym.clone(), | ^^^^^^^^ help: remove this | note: this value is dropped without further use --> partiql-logical-planner/src/typer.rs:160:33 | 160 | ... sym.clone(), | ^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone = note: `#[warn(clippy::redundant_clone)]` on by default

warning: function `string_to_sym` is never used --> partiql-logical-planner/src/typer.rs:283:4 | 283 | fn string_to_sym(name: &str) -> SymbolPrimitive { | ^^^^^^^^^^^^^

warning: multiple associated items are never used --> partiql-logical-planner/src/typer.rs:49:12 | 48 | impl<'c> PlanTyper<'c> { | ---------------------- associated items in this implementation 49 | pub fn new(catalog: &'c dyn Catalog, lg: &LogicalPlan<BindingsOp>) -> Self { | ^^^ ... 59 | pub fn type_plan(&mut self) -> Result<PartiqlType, PlanErr> { | ^^^^^^^^^ ... 79 | fn type_binop(&mut self, op: &BindingsOp) -> () { | ^^^^^^^^^^ ... 136 | fn type_vexpr(&mut self, v: &ValueExpr, lookup_order: LookupOrder) -> () { | ^^^^^^^^^^ ... 230 | fn sort(&self) -> Result<Vec<NodeIndex>, PlanErr> { | ^^^^ ... 245 | fn to_stable_graph(&self) -> Result<StableGraph<BindingsOp, u8>, PlanErr> { | ^^^^^^^^^^^^^^^ ... 268 | fn element_type<'a>(&'a self, ty: &'a PartiqlType) -> &PartiqlType { | ^^^^^^^^^^^^ ... 278 | fn local_type_env(&self) -> &IndexMap<SymbolPrimitive, PartiqlType> { | ^^^^^^^^^^^^^^

warning: struct `PlanTyper` is never constructed --> partiql-logical-planner/src/typer.rs:40:12 | 40 | pub struct PlanTyper<'c> { | ^^^^^^^^^

warning: enum `LookupOrder` is never used --> partiql-logical-planner/src/typer.rs:22:6 | 22 | enum LookupOrder { | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: immediately dereferencing a reference --> partiql-logical-planner/src/typer.rs:186:33 | 186 | self.type_vexpr(*&v, LookupOrder::LocalGlobal); | ^^^ help: try this: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof = note: `#[warn(clippy::deref_addrof)]` on by default

warning: unneeded unit return type --> partiql-logical-planner/src/typer.rs:136:71 | 136 | fn type_vexpr(&mut self, v: &ValueExpr, lookup_order: LookupOrder) -> () { | ^^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit

warning: unneeded unit return type --> partiql-logical-planner/src/typer.rs:79:46 | 79 | fn type_binop(&mut self, op: &BindingsOp) -> () { | ^^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> partiql-logical-planner/src/typer.rs:274:18 | 274 | _ => &ty, | ^^^ help: change this to: `ty` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: deref which would be done by auto-deref --> partiql-logical-planner/src/typer.rs:186:33 | 186 | self.type_vexpr(*&v, LookupOrder::LocalGlobal); | ^^^ help: try this: `&v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default

warning: redundant clone --> partiql-logical-planner/src/typer.rs:223:76 | 223 | let new_type_env = IndexMap::from([(string_to_sym("_1"), ty.clone())]); | ^^^^^^^^ help: remove this | note: this value is dropped without further use --> partiql-logical-planner/src/typer.rs:223:74 | 223 | let new_type_env = IndexMap::from([(string_to_sym("_1"), ty.clone())]); | ^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone

warning: redundant clone --> partiql-logical-planner/src/typer.rs:160:36 | 160 | ... sym.clone(), | ^^^^^^^^ help: remove this | note: this value is dropped without further use --> partiql-logical-planner/src/typer.rs:160:33 | 160 | ... sym.clone(), | ^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone = note: `#[warn(clippy::redundant_clone)]` on by default

warning: function `string_to_sym` is never used --> partiql-logical-planner/src/typer.rs:283:4 | 283 | fn string_to_sym(name: &str) -> SymbolPrimitive { | ^^^^^^^^^^^^^

warning: multiple associated items are never used --> partiql-logical-planner/src/typer.rs:49:12 | 48 | impl<'c> PlanTyper<'c> { | ---------------------- associated items in this implementation 49 | pub fn new(catalog: &'c dyn Catalog, lg: &LogicalPlan<BindingsOp>) -> Self { | ^^^ ... 59 | pub fn type_plan(&mut self) -> Result<PartiqlType, PlanErr> { | ^^^^^^^^^ ... 79 | fn type_binop(&mut self, op: &BindingsOp) -> () { | ^^^^^^^^^^ ... 136 | fn type_vexpr(&mut self, v: &ValueExpr, lookup_order: LookupOrder) -> () { | ^^^^^^^^^^ ... 230 | fn sort(&self) -> Result<Vec<NodeIndex>, PlanErr> { | ^^^^ ... 245 | fn to_stable_graph(&self) -> Result<StableGraph<BindingsOp, u8>, PlanErr> { | ^^^^^^^^^^^^^^^ ... 268 | fn element_type<'a>(&'a self, ty: &'a PartiqlType) -> &PartiqlType { | ^^^^^^^^^^^^ ... 278 | fn local_type_env(&self) -> &IndexMap<SymbolPrimitive, PartiqlType> { | ^^^^^^^^^^^^^^

warning: struct `PlanTyper` is never constructed --> partiql-logical-planner/src/typer.rs:40:12 | 40 | pub struct PlanTyper<'c> { | ^^^^^^^^^

warning: enum `LookupOrder` is never used --> partiql-logical-planner/src/typer.rs:22:6 | 22 | enum LookupOrder { | ^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

warning: immediately dereferencing a reference --> partiql-logical-planner/src/typer.rs:186:33 | 186 | self.type_vexpr(*&v, LookupOrder::LocalGlobal); | ^^^ help: try this: `v` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof = note: `#[warn(clippy::deref_addrof)]` on by default

warning: unneeded unit return type --> partiql-logical-planner/src/typer.rs:136:71 | 136 | fn type_vexpr(&mut self, v: &ValueExpr, lookup_order: LookupOrder) -> () { | ^^^^^^ help: remove the `-> ()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit