-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial sql call aggregation function implementation #335
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
==========================================
+ Coverage 81.25% 81.30% +0.05%
==========================================
Files 44 44
Lines 9942 10261 +319
==========================================
+ Hits 8078 8343 +265
- Misses 1864 1918 +54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 2432 Number failing in both: 415 Number passing in Base (11e5623) but now fail: 0 Number failing in Base (11e5623) but now pass: 267 The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass: Click here to see
|
832a1f1
to
89e34a5
Compare
Implements SQL aggregation functions (AVG, COUNT, MAX, MIN, SUM) in the evaluator.
Performs some rewrites:
GROUP BY
are rewritten to include aGROUP BY true AS $__gk
SELECT a, SUM(b) FROM t GROUP BY a
->SELECT a, $__agg_1 FROM t GROUP BY a
SELECT t.a + 1 AS a FROM t GROUP BY t.a + 1 AS some_group_alias
->SELECT some_group_alias AS a FROM t GROUP BY t.a + 1 AS some_group_alias
NULL/MISSING in GROUP BY values Fixthese conformance tests are incorrectGROUP BY
when value isMISSING
#328Figure out proper lowering of PartiQL/top-level aggregation functions and SQL aggregation functionsthis shouldn't be an issue if we disallow using PartiQL/top-level aggregation functions in SQL aggregation contexts. See Aggregation functions COLL_XXX() vs XXX() and ALL/DISTINCT modifiers in them partiql-lang#16By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.