Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds implementation of path wildcard and path unpivot expressions #402

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alancai98
Copy link
Member

Implements path wildcard (e.g. foo[*].a[*].b) and path unpivot expressions (e.g. bar.*.c.*.d). Also

  • adds lowering of IN expressions
  • updates partiql-tests git submodule

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 self-assigned this Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch coverage: 92.74% and project coverage change: +0.07 🎉

Comparison is base (139b276) 81.15% compared to head (b5d256c) 81.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #402      +/-   ##
==========================================
+ Coverage   81.15%   81.23%   +0.07%     
==========================================
  Files          56       56              
  Lines       14737    14825      +88     
  Branches    14737    14825      +88     
==========================================
+ Hits        11960    12043      +83     
+ Misses       2260     2257       -3     
- Partials      517      525       +8     
Impacted Files Coverage Δ
partiql-logical/src/lib.rs 42.35% <ø> (+0.58%) ⬆️
partiql-eval/src/eval/expr/mod.rs 83.18% <91.34%> (+0.45%) ⬆️
partiql-eval/src/plan.rs 91.60% <100.00%> (+0.02%) ⬆️
partiql-logical-planner/src/lower.rs 85.10% <100.00%> (+0.26%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Conformance comparison report

Base (139b276) d0066c6 +/-
% Passing 83.29% 84.13% 0.84%
✅ Passing 5264 5317 53
❌ Failing 1056 1003 -53
🔶 Ignored 0 0 0
Total Tests 6320 6320 0

Number passing in both: 5264

Number failing in both: 1003

Number passing in Base (139b276) but now fail: 0

Number failing in Base (139b276) but now pass: 53

The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see
  • partiql_tests::eval::primitives::path::path::path::permissive_path_wild_card_over_scalar_multiple
  • partiql_tests::eval::primitives::path::path::path::permissive_path_double_unpivot_wild_card
  • partiql_tests::eval::primitives::path::path::path::permissive_path_wildcard
  • partiql_tests::eval::primitives::path::path::path::strict_path_unpivot_wildcard
  • partiql_tests::eval::primitives::operators::operators::in_operator::r#in::strict_in_predicate_with_expression_on_right_side
  • partiql_tests::eval::primitives::path::path::path::permissive_path_unpivot_wildcard
  • partiql_tests::eval::primitives::path::path::path::permissive_path_simple_wildcard
  • partiql_tests::eval_equiv::spec_tests::section_4::permissive_equiv_wildcard_steps_struct
  • partiql_tests::eval::query::select::select::select::select_list_item::permissive_select_implicit_and_explicit_alias_single_source_hoisted
  • partiql_tests::eval::query::select::select::from_clause::path_in_from_clause::permissive_select_star_single_source_hoisted
  • partiql_tests::eval::primitives::operators::operators::in_operator::r#in::strict_not_in_predicate_single_item_list_var
  • partiql_tests::eval::query::select::select::select::select_list_item::strict_select_implicit_and_explicit_alias_single_source_hoisted
  • partiql_tests::eval::primitives::path::path::path::strict_path_unpivot_wild_card_over_scalar
  • partiql_tests::eval::query::select::select::select_mysql::select::strict_mysql_select_30
  • partiql_tests::eval::primitives::path::path::path::permissive_path_wild_card_over_scalar
  • partiql_tests::eval::primitives::path::path::path_unpivot_missing::strict_path_unpivot_empty_struct_2
  • partiql_tests::eval::primitives::operators::operators::in_operator::r#in::strict_in_predicate_single_item_list_var
  • partiql_tests::eval::primitives::path::path::path::strict_path_simple_wildcard
  • partiql_tests::eval::query::group_by::group_by::group_by::simple_group_by::strict_group_by_with_having_expression
  • partiql_tests::eval::query::select::select::select_mysql::select::permissive_mysql_select_30
  • partiql_tests::eval::primitives::operators::operators::in_operator::r#in::permissive_not_in_predicate_single_item_list_var
  • partiql_tests::eval::primitives::operators::operators::in_operator::r#in::permissive_in_predicate_with_expression_on_right_side
  • partiql_tests::eval::primitives::path::path::path_unpivot_missing::strict_path_unpivot_empty_struct_1
  • partiql_tests::eval::primitives::path::path::path::strict_path_double_wild_card
  • partiql_tests::eval::primitives::operators::operators::in_operator::r#in::strict_in_predicate_single_expr
  • partiql_tests::eval::query::group_by::group_by::group_by::simple_group_by::permissive_group_by_with_having_expression
  • partiql_tests::eval::primitives::operators::operators::in_operator::r#in::permissive_not_in_predicate_with_expression_on_right_side
  • partiql_tests::eval::primitives::path::path::path_unpivot_missing::permissive_path_unpivot_empty_struct_1
  • partiql_tests::eval::query::select::select::from_clause::path_in_from_clause::strict_select_star_single_source_hoisted
  • partiql_tests::eval::primitives::path::path::path_unpivot_missing::permissive_path_unpivot_empty_struct_2
  • partiql_tests::eval::primitives::path::path::path::permissive_path_wild_card_over_struct_multiple
  • partiql_tests::eval::primitives::path::path::path::strict_path_wildcard
  • partiql_tests::eval::primitives::path::path::path::strict_path_wild_card_over_scalar
  • partiql_tests::eval::primitives::path::path::path::strict_path_double_unpivot_wild_card
  • partiql_tests::eval::primitives::path::path::path::permissive_path_unpivot_wild_card_over_struct_multiple
  • partiql_tests::eval_equiv::spec_tests::section_4::strict_equiv_wildcard_steps_struct
  • partiql_tests::eval_equiv::spec_tests::section_4::strict_equiv_wildcard_steps_collection
  • partiql_tests::eval::primitives::path::path::path_unpivot_missing::permissive_path_unpivot_empty_struct_3
  • partiql_tests::eval::primitives::path::path::path::permissive_path_unpivot_wild_card_over_scalar_multiple
  • partiql_tests::eval::primitives::path::path::path::strict_path_wild_card_over_struct_multiple
  • partiql_tests::eval::primitives::path::path::path::permissive_path_unpivot_wildcard_fields_after
  • partiql_tests::eval::primitives::path::path::path::strict_path_wild_card_over_scalar_multiple
  • partiql_tests::eval::primitives::path::path::path::permissive_path_double_wild_card
  • partiql_tests::eval::primitives::operators::operators::in_operator::r#in::permissive_in_predicate_single_expr
  • partiql_tests::eval::primitives::path::path::path::strict_path_unpivot_wild_card_over_struct_multiple
  • partiql_tests::eval::primitives::operators::operators::in_operator::r#in::permissive_not_in_predicate_single_expr
  • partiql_tests::eval::primitives::path::path::path::strict_path_unpivot_wildcard_fields_after
  • partiql_tests::eval_equiv::spec_tests::section_4::permissive_equiv_wildcard_steps_collection
  • partiql_tests::eval::primitives::operators::operators::in_operator::r#in::permissive_in_predicate_single_item_list_var
  • partiql_tests::eval::primitives::path::path::path_unpivot_missing::strict_path_unpivot_empty_struct_3
  • partiql_tests::eval::primitives::operators::operators::in_operator::r#in::strict_not_in_predicate_with_expression_on_right_side
  • partiql_tests::eval::primitives::path::path::path::permissive_path_unpivot_wild_card_over_scalar
  • partiql_tests::eval::primitives::path::path::path::strict_path_unpivot_wild_card_over_scalar_multiple

@alancai98 alancai98 requested review from jpschorr and am357 July 5, 2023 23:43
@alancai98 alancai98 marked this pull request as ready for review July 5, 2023 23:43
@alancai98 alancai98 marked this pull request as draft July 6, 2023 20:57
@alancai98
Copy link
Member Author

Converting to draft to see if I can reduce the cloning for non-PathWildCard and non-PathUnpivot expressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant