PartiQL types rename #469
Merged
PartiQL types rename #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors `partiql-types` by adding `PartiqlShape`; with this model, `PartiqlShape` is one of `Dynamic` (ex. `Any`), `AnyOf`, `Static`, or `Undefined`. `nullability` is defined as part of `StaticType`. The large diff is as a result of the `PartiqlType` refactoring.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
- Coverage 80.50% 80.50% -0.01%
==========================================
Files 66 66
Lines 17508 17503 -5
Branches 17508 17503 -5
==========================================
- Hits 14095 14090 -5
Misses 2977 2977
Partials 436 436 ☔ View full report in Codecov by Sentry. |
jpschorr
approved these changes
Jun 24, 2024
Conformance comparison report
Number passing in both: 5731 Number failing in both: 612 Number passing in Base (0ff57fe) but now fail: 0 Number failing in Base (0ff57fe) but now pass: 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Renames
StaticTypeVarianttoStaticto make it shorter and the usage easier—it is behavioral preserving.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.