Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeBuilder for building ASTs #476

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Add NodeBuilder for building ASTs #476

merged 3 commits into from
Jul 10, 2024

Conversation

jpschorr
Copy link
Contributor

This is mostly a refactor of existing functionality from the parser that moves it to the ast package and makes it public.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpschorr jpschorr requested a review from am357 July 10, 2024 22:24
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (684fff3) to head (6b27530).

Files Patch % Lines
partiql-ast/src/builder.rs 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
- Coverage   81.18%   81.17%   -0.01%     
==========================================
  Files          67       68       +1     
  Lines       18563    18570       +7     
  Branches    18563    18570       +7     
==========================================
+ Hits        15070    15074       +4     
- Misses       3051     3054       +3     
  Partials      442      442              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jul 10, 2024

Conformance comparison report

Base (684fff3) f6b37f2 +/-
% Passing 90.35% 90.35% 0.00%
✅ Passing 5731 5731 0
❌ Failing 612 612 0
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5731

Number failing in both: 612

Number passing in Base (684fff3) but now fail: 0

Number failing in Base (684fff3) but now pass: 0

partiql-ast/src/builder.rs Show resolved Hide resolved
@jpschorr jpschorr merged commit 1b22fb6 into main Jul 10, 2024
19 checks passed
@jpschorr jpschorr deleted the feat-add-ast-builder branch July 10, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants