Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more informational Display for Static types #489

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

jpschorr
Copy link
Contributor

@jpschorr jpschorr commented Aug 20, 2024

Currently used in another project to output types like:

AnyOf(NOT NULL String, Int8, String, DateTime, String, Bool, String, AnyOf({value: Decimal(7,4), currency: String}, Decimal(3,2), Decimal(3,2), Decimal(4,2), Decimal(5,2)), {test_decimal: Decimal(3,0), test_string: String}, {nested_struct: {nested_struct: {nested_struct: {nested_struct: {nested_struct: {test_int: Int8}}}}}}),

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 80.57%. Comparing base (843d3ee) to head (390ff2c).
Report is 1 commits behind head on main.

Files Patch % Lines
partiql-types/src/lib.rs 60.00% 17 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   80.61%   80.57%   -0.04%     
==========================================
  Files          70       70              
  Lines       18997    19025      +28     
  Branches    18997    19025      +28     
==========================================
+ Hits        15315    15330      +15     
- Misses       3238     3248      +10     
- Partials      444      447       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Conformance comparison report

Base (843d3ee) 36533c5 +/-
% Passing 90.35% 90.35% 0.00%
✅ Passing 5731 5731 0
❌ Failing 612 612 0
🔶 Ignored 0 0 0
Total Tests 6343 6343 0

Number passing in both: 5731

Number failing in both: 612

Number passing in Base (843d3ee) but now fail: 0

Number failing in Base (843d3ee) but now pass: 0

@jpschorr jpschorr merged commit 298a7ac into main Aug 20, 2024
18 of 19 checks passed
@jpschorr jpschorr deleted the feat-additional-type-display branch August 20, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants