Skip to content

Add metas to PartiQL Commons

Sign in for the full log view
GitHub Actions / clippy succeeded Aug 16, 2024 in 0s

clippy

20 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 20
Note 0
Help 0

Versions

  • rustc 1.80.1 (3f5fd8dd4 2024-08-06)
  • cargo 1.80.1 (376290515 2024-07-16)
  • clippy 0.1.80 (3f5fd8d 2024-08-06)

Annotations

Check warning on line 23 in partiql-conformance-tests/src/bin/generate_comparison_report.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

doc list item missing indentation

warning: doc list item missing indentation
  --> partiql-conformance-tests/src/bin/generate_comparison_report.rs:23:5
   |
23 | /// regressed behavior)
   |     ^
   |
   = help: if this is supposed to be its own paragraph, add a blank line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
   = note: `#[warn(clippy::doc_lazy_continuation)]` on by default
help: indent this line
   |
23 | ///   regressed behavior)
   |     ++

Check warning on line 149 in partiql-eval/src/eval/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unexpected `cfg` condition value: `serde`

warning: unexpected `cfg` condition value: `serde`
   --> partiql-eval/src/eval/mod.rs:149:12
    |
149 | #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
    |            ^^^^^^^^^^^^^^^^^
    |
    = note: expected values for `feature` are: `default`
    = help: consider adding `serde` as a feature in `Cargo.toml`
    = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
    = note: `#[warn(unexpected_cfgs)]` on by default

Check warning on line 164 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:164:13
    |
163 |     pub struct EvaluationFailAssertion {
    |                ----------------------- field in this struct
164 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 157 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:157:13
    |
156 |     pub struct EvaluationSuccessAssertion {
    |                -------------------------- field in this struct
157 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 152 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:152:13
    |
151 |     pub struct StaticAnalysisFailAssertion {
    |                --------------------------- field in this struct
152 |         pub result: String,
    |             ^^^^^^
    |
    = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 147 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:147:13
    |
146 |     pub struct SyntaxFailAssertion {
    |                ------------------- field in this struct
147 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 142 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:142:13
    |
141 |     pub struct SyntaxSuccessAssertion {
    |                ---------------------- field in this struct
142 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 75 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:75:28
   |
75 |         StaticAnalysisFail(StaticAnalysisFailAssertion),
   |         ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
75 |         StaticAnalysisFail(()),
   |                            ~~

Check warning on line 74 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:74:20
   |
74 |         SyntaxFail(SyntaxFailAssertion),
   |         ---------- ^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
74 |         SyntaxFail(()),
   |                    ~~

Check warning on line 73 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:73:23
   |
73 |         SyntaxSuccess(SyntaxSuccessAssertion),
   |         ------------- ^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
73 |         SyntaxSuccess(()),
   |                       ~~

Check warning on line 164 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:164:13
    |
163 |     pub struct EvaluationFailAssertion {
    |                ----------------------- field in this struct
164 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 157 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:157:13
    |
156 |     pub struct EvaluationSuccessAssertion {
    |                -------------------------- field in this struct
157 |         pub result: String,
    |             ^^^^^^
    |
    = note: `EvaluationSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 152 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:152:13
    |
151 |     pub struct StaticAnalysisFailAssertion {
    |                --------------------------- field in this struct
152 |         pub result: String,
    |             ^^^^^^
    |
    = note: `StaticAnalysisFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 147 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:147:13
    |
146 |     pub struct SyntaxFailAssertion {
    |                ------------------- field in this struct
147 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxFailAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 142 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `result` is never read

warning: field `result` is never read
   --> partiql-conformance-test-generator/src/schema.rs:142:13
    |
141 |     pub struct SyntaxSuccessAssertion {
    |                ---------------------- field in this struct
142 |         pub result: String,
    |             ^^^^^^
    |
    = note: `SyntaxSuccessAssertion` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 75 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:75:28
   |
75 |         StaticAnalysisFail(StaticAnalysisFailAssertion),
   |         ------------------ ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
75 |         StaticAnalysisFail(()),
   |                            ~~

Check warning on line 74 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:74:20
   |
74 |         SyntaxFail(SyntaxFailAssertion),
   |         ---------- ^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
74 |         SyntaxFail(()),
   |                    ~~

Check warning on line 73 in partiql-conformance-test-generator/src/schema.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `0` is never read

warning: field `0` is never read
  --> partiql-conformance-test-generator/src/schema.rs:73:23
   |
73 |         SyntaxSuccess(SyntaxSuccessAssertion),
   |         ------------- ^^^^^^^^^^^^^^^^^^^^^^
   |         |
   |         field in this variant
   |
   = note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
   |
73 |         SyntaxSuccess(()),
   |                       ~~

Check warning on line 201 in partiql-common/src/metadata.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variants `Float32` and `Decimal` are never constructed

warning: variants `Float32` and `Decimal` are never constructed
   --> partiql-common/src/metadata.rs:201:5
    |
195 | pub enum PartiqlMetaValue<T>
    |          ---------------- variants in this enum
...
201 |     Float32(f32),
    |     ^^^^^^^
202 |     Float64(f64),
203 |     Decimal(Decimal),
    |     ^^^^^^^
    |
    = note: `PartiqlMetaValue` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis

Check warning on line 21 in partiql-common/src/metadata.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

multiple associated items are never used

warning: multiple associated items are never used
   --> partiql-common/src/metadata.rs:21:12
    |
17  | / impl<T> PartiqlMetadata<T>
18  | | where
19  | |     T: Eq + Clone + Hash + Borrow<str>,
    | |_______________________________________- associated items in this implementation
20  |   {
21  |       pub fn new() -> Self {
    |              ^^^
...
27  |       pub fn insert(&mut self, key: T, value: PartiqlMetaValue<T>) {
    |              ^^^^^^
...
31  |       pub fn get(&self, key: &T) -> Option<&PartiqlMetaValue<T>> {
    |              ^^^
...
35  |       pub fn get_mut(&mut self, key: &T) -> Option<&mut PartiqlMetaValue<T>> {
    |              ^^^^^^^
...
39  |       pub fn contains_key(&self, key: &T) -> bool {
    |              ^^^^^^^^^^^^
...
43  |       pub fn keys(&self) -> impl Iterator<Item = &T> {
    |              ^^^^
...
47  |       pub fn values(&self) -> impl Iterator<Item = &PartiqlMetaValue<T>> {
    |              ^^^^^^
...
51  |       pub fn values_mut(&mut self) -> impl Iterator<Item = &mut PartiqlMetaValue<T>> {
    |              ^^^^^^^^^^
...
55  |       pub fn entry(&mut self, key: T) -> Entry<'_, T, PartiqlMetaValue<T>> {
    |              ^^^^^
...
59  |       pub fn clear(&mut self) {
    |              ^^^^^
...
63  |       pub fn remove(&mut self, key: &T) -> Option<PartiqlMetaValue<T>> {
    |              ^^^^^^
...
67  |       pub fn len(&self) -> usize {
    |              ^^^
...
75  |       pub fn iter_mut(&mut self) -> impl Iterator<Item = (&T, &mut PartiqlMetaValue<T>)> {
    |              ^^^^^^^^
...
79  |       pub fn vec_value(&self, key: &str) -> Option<Vec<PartiqlMetaValue<T>>> {
    |              ^^^^^^^^^
...
88  |       pub fn bool_value(&self, key: &str) -> Option<bool> {
    |              ^^^^^^^^^^
...
97  |       pub fn f32_value(&self, key: &str) -> Option<f32> {
    |              ^^^^^^^^^
...
106 |       pub fn f64_value(&self, key: &str) -> Option<f64> {
    |              ^^^^^^^^^
...
115 |       pub fn decimal_value(&self, key: &str) -> Option<Decimal> {
    |              ^^^^^^^^^^^^^
...
124 |       pub fn i32_value(&self, key: &str) -> Option<i32> {
    |              ^^^^^^^^^
...
133 |       pub fn i64_value(&self, key: &str) -> Option<i64> {
    |              ^^^^^^^^^
...
142 |       pub fn map_value(&self, key: &str) -> Option<PartiqlMetadata<T>> {
    |              ^^^^^^^^^
...
151 |       pub fn string_value(&self, key: &str) -> Option<String> {
    |              ^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default