Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use immutable Jackson (De)serializer interfaces #55

Merged
merged 2 commits into from
Aug 20, 2021
Merged

Conversation

bdemers
Copy link
Contributor

@bdemers bdemers commented Jul 12, 2021

Also: bump version of SpotBugs

Bumps [spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.2.3 to 4.3.0.
- [Release notes](https://github.com/spotbugs/spotbugs-maven-plugin/releases)
- [Commits](spotbugs/spotbugs-maven-plugin@spotbugs-maven-plugin-4.2.3...spotbugs-maven-plugin-4.3.0)

---
updated-dependencies:
- dependency-name: com.github.spotbugs:spotbugs-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #55 (b96afd5) into main (3e9ccd2) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #55      +/-   ##
============================================
+ Coverage     83.10%   83.15%   +0.04%     
- Complexity      251      252       +1     
============================================
  Files            54       54              
  Lines           734      736       +2     
  Branches         53       53              
============================================
+ Hits            610      612       +2     
  Misses           94       94              
  Partials         30       30              
Impacted Files Coverage Δ
...paseto/jpaseto/io/jackson/JacksonDeserializer.java 96.66% <100.00%> (+0.23%) ⬆️
...v/paseto/jpaseto/io/jackson/JacksonSerializer.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e9ccd2...b96afd5. Read the comment docs.

Current versions of Jackson recommend the use of ObjectReader/Writer as opposed to holding a ref to a mutable ObjectMapper
@bdemers bdemers merged commit ae2f9c2 into main Aug 20, 2021
@bdemers bdemers deleted the immutiable-jackson branch August 20, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant