Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid failing to switch device prematurely #721

Closed
HGSilveri opened this issue Aug 12, 2024 · 0 comments · Fixed by #724
Closed

Avoid failing to switch device prematurely #721

HGSilveri opened this issue Aug 12, 2024 · 0 comments · Fixed by #724
Milestone

Comments

@HGSilveri
Copy link
Collaborator

Currently, Sequence.switch_device(strict=True) is unnecessarily rigid in some cases:

  • It requires the RydbergEOM configs match exactly between channels, which will become even more problematic now that the lightshift coefficients can be specified
  • It enforces matching between channel parameters that might not be relevant for the particular sequence being switched, eg.
    • bottom_detuning and total_bottom_detuning are enforced during reconstruction so there is no need to see if they match
    • The parameters that are required to match in eom_config depend on whether the amplitude of the pulses is high enough to make the limiting beam reach the maximum amplitude

It would be preferable to not fail unnecessarily and instead check that channel samples all match between the old and the new sequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant