You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditions on total_bottom_detuning and bottom_detuning for DMM channels, and on EOM config for channels using EOM (eom config being the same) are deleted.
They are replaced by a condition on the building of the sequence being possible, and the samples of the Sequence being unaffected by the switching of the device.
To do this, we first loop over all the possible matchings between declared channels and devices in the new device. For the one having correct type, addressing, modulations, ... we try to build the associated sequence. If the strict condition is provided and the Sequence can be successfully built, we check that the samples are the same for the two Sequences. Finally, the Sequence built with the first compatible matching.
If no matching is found to be compatible, we go through the same error detection process as before to provide a good hint on the error. Closes#721
Looking good overall! The switch_device() method is getting too bulky, how would you feel about moving it into a separate file?
I have created a "helpers" folder, and placed this function switch_device in it. I have also moved _seq_str.py to this file since it is also a helper function. The other files does not seem to contain only a helper function, so I have decided to let it like that.
I have created a "helpers" folder, and placed this function switch_device in it. I have also moved _seq_str.py to this file since it is also a helper function. The other files does not seem to contain only a helper function, so I have decided to let it like that.
This is okay with me. I think other files could potentially go there but it's not out-of-scope for this PR.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditions on total_bottom_detuning and bottom_detuning for DMM channels, and on EOM config for channels using EOM (eom config being the same) are deleted.
They are replaced by a condition on the building of the sequence being possible, and the samples of the Sequence being unaffected by the switching of the device.
To do this, we first loop over all the possible matchings between declared channels and devices in the new device. For the one having correct type, addressing, modulations, ... we try to build the associated sequence. If the strict condition is provided and the Sequence can be successfully built, we check that the samples are the same for the two Sequences. Finally, the Sequence built with the first compatible matching.
If no matching is found to be compatible, we go through the same error detection process as before to provide a good hint on the error.
Closes #721