-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address qubits with indices #356
Conversation
…ssue" This reverts commit 838d5fe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first batch of comment, but it's looking pretty good already!
Good job @CdeTerra ! 🎉 🎉 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be continued...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Only a couple things left to address, thanks a lot for your help!
Main changes: - 3921795 Remove string variables (#365) - b23ff22 Splitting `pulser` into `pulser-core` and `pulser-simulation`. (#362) - 4f684f3 Address qubits with indices (#356) - f2ee5e2 Make evaluation times uniform including final time (#330) - c34dffb Changes for compatibility with upcoming export format (#353) - 3ac1f66 Sequence sampler (#345)
Main changes: - 3921795 Remove string variables (#365) - b23ff22 Splitting `pulser` into `pulser-core` and `pulser-simulation`. (#362) - 4f684f3 Address qubits with indices (#356) - f2ee5e2 Make evaluation times uniform including final time (#330) - c34dffb Changes for compatibility with upcoming export format (#353) - 3ac1f66 Sequence sampler (#345)
Allow to address qubits with indices, allowing to use integer parameters to select them. Will cover
target
andphase_shift
functions.