Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address qubits with indices #356

Merged
merged 22 commits into from
Apr 13, 2022
Merged

Address qubits with indices #356

merged 22 commits into from
Apr 13, 2022

Conversation

CdeTerra
Copy link
Collaborator

@CdeTerra CdeTerra commented Apr 7, 2022

Allow to address qubits with indices, allowing to use integer parameters to select them. Will cover target and phase_shift functions.

Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first batch of comment, but it's looking pretty good already!

pulser/register/mappable_reg.py Outdated Show resolved Hide resolved
pulser/register/mappable_reg.py Outdated Show resolved Hide resolved
pulser/register/mappable_reg.py Outdated Show resolved Hide resolved
pulser/sequence.py Show resolved Hide resolved
pulser/sequence.py Outdated Show resolved Hide resolved
@HGSilveri
Copy link
Collaborator

Good job @CdeTerra ! 🎉 🎉 🎉

@CdeTerra CdeTerra marked this pull request as ready for review April 11, 2022 09:32
@CdeTerra CdeTerra requested a review from HGSilveri April 11, 2022 09:33
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be continued...

pulser/sequence.py Outdated Show resolved Hide resolved
pulser/sequence.py Outdated Show resolved Hide resolved
pulser/sequence.py Show resolved Hide resolved
pulser/sequence.py Outdated Show resolved Hide resolved
pulser/sequence.py Outdated Show resolved Hide resolved
pulser/sequence.py Show resolved Hide resolved
pulser/sequence.py Show resolved Hide resolved
pulser/sequence.py Outdated Show resolved Hide resolved
pulser/sequence.py Outdated Show resolved Hide resolved
pulser/sequence.py Show resolved Hide resolved
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Only a couple things left to address, thanks a lot for your help!

pulser/tests/test_sequence.py Show resolved Hide resolved
pulser/tests/test_sequence.py Outdated Show resolved Hide resolved
pulser/sequence.py Outdated Show resolved Hide resolved
@HGSilveri HGSilveri merged commit 4f684f3 into develop Apr 13, 2022
@HGSilveri HGSilveri deleted the address-qubits-with-indices branch April 13, 2022 07:51
@HGSilveri HGSilveri mentioned this pull request May 13, 2022
HGSilveri added a commit that referenced this pull request May 13, 2022
Main changes:

- 3921795 Remove string variables (#365)
- b23ff22 Splitting `pulser` into `pulser-core` and `pulser-simulation`. (#362)
- 4f684f3 Address qubits with indices (#356)
- f2ee5e2 Make evaluation times uniform including final time (#330)
- c34dffb Changes for compatibility with upcoming export format (#353)
- 3ac1f66 Sequence sampler (#345)
HGSilveri added a commit that referenced this pull request May 13, 2022
Main changes:
- 3921795 Remove string variables (#365)
- b23ff22 Splitting `pulser` into `pulser-core` and `pulser-simulation`. 
(#362)
- 4f684f3 Address qubits with indices (#356)
- f2ee5e2 Make evaluation times uniform including final time (#330)
- c34dffb Changes for compatibility with upcoming export format (#353)
- 3ac1f66 Sequence sampler (#345)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants