Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements for sequence building #364

Merged
merged 7 commits into from
Apr 13, 2022
Merged

Conversation

CdeTerra
Copy link
Collaborator

  • Add find_indices function to Register type, so that it's easier to switch between mappable and normal registers, using similar functions
  • Improve docstrings
  • Fix missing case of warning

@CdeTerra CdeTerra marked this pull request as draft April 13, 2022 13:10
@CdeTerra CdeTerra marked this pull request as ready for review April 13, 2022 13:37
@CdeTerra CdeTerra requested a review from HGSilveri April 13, 2022 13:38
Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

Comment on lines +92 to +115
"""Computes indices of qubits.

This can especially be useful when building a Pulser Sequence
with a parameter denoting qubits.

Example:
Let ``reg`` be a register with qubit Ids "a", "b" and "c":

>>> reg.find_indices(["a", "b", "c", "a"])

It returns ``[0, 1, 2, 0]``, following the qubit order of the
register.

Then, it is possible to use these indices when building a
sequence, typically to instantiate a ``VariableArray``,
that can be provided as an argument to ``target_index``
and ``phase_shift_index``.

Args:
id_list (typing::Sequence[QubitId]): IDs of the qubits to denote

Returns:
list[int]: Indices of the qubits to denote, only valid for the
given mapping.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very detailed, nice!

@HGSilveri HGSilveri merged commit 5461f77 into develop Apr 13, 2022
@HGSilveri HGSilveri deleted the improve-indices branch April 13, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants