Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for emulation of empty sequences #531

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Fixes for emulation of empty sequences #531

merged 2 commits into from
Jun 5, 2023

Conversation

HGSilveri
Copy link
Collaborator

  • Allows for emulation of sequences with only delays by adding intial_targets information to ChannelSamples
  • Fixes determination of max_step in QutipEmulator.run() when there is no non-zero pulse

@HGSilveri HGSilveri requested a review from a-corni June 5, 2023 11:27
a-corni
a-corni approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@a-corni a-corni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! At first I was questioning the purpose of this changes, but I understood with the tests that it can be interesting for noise simulation.

@HGSilveri
Copy link
Collaborator Author

Looks good to me ! At first I was questioning the purpose of this changes, but I understood with the tests that it can be interesting for noise simulation.

Indeed. Also, it was not failing properly when given a sequence with only delays (because there were instruction and the max_duration was not zero, so it just went ahead until it failed)

@HGSilveri HGSilveri merged commit 23fc359 into develop Jun 5, 2023
@HGSilveri HGSilveri deleted the hs/empty-seq-fix branch June 5, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-corni a-corni a-corni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HGSilveri @a-corni