Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate device, seq against the abstract representation schema in serialization #550

Merged
merged 6 commits into from
Jul 11, 2023

Conversation

a-corni
Copy link
Collaborator

@a-corni a-corni commented Jul 7, 2023

I have noticed that only sequence and device are validated against the abstract representation schema in deserializer.py.
Closes #535.

Copy link
Collaborator

@HGSilveri HGSilveri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job!

@a-corni a-corni merged commit 031523b into develop Jul 11, 2023
6 checks passed
@HGSilveri HGSilveri deleted the validate_serialization branch July 24, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate objects against the abstract representation schema after serialization
2 participants