Correct XY Hamiltonian interaction term #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
HGSilveri
force-pushed
the
hs/fix-xy-sign
branch
from
79f7f5b
to
4a59db1
Compare
HGSilveri
changed the title
HGSilveri
force-pushed
the
hs/fix-xy-sign
branch
from
4a59db1
to
5197bf8
Compare
Merged
HGSilveri
added a commit
that referenced
this pull request
Oct 9, 2024
**Fixes**: - Correct XY Hamiltonian interaction term (#744) **Removals**: - Drop support for Python 3.8 (#743) - Remove Simulation() and pulser.simulation (#736) - Remove legacy JSON serialization methods for Sequence (#737) - Remove Chadoq2 and IroiseMVP (#735) - Remove references to "submission" on RemoteResults (#738) - Remove legacy NoiseModel (#734)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a wrong factor of
/2in the XY interaction term: what should have been(1 - 3*cos**2)was rather(1 - 3*cos**2) / 2.This PR: