Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned requests conflicts with jupyterlab-server. #58

Closed
picbeats opened this issue Jan 18, 2023 · 2 comments
Closed

Pinned requests conflicts with jupyterlab-server. #58

picbeats opened this issue Jan 18, 2023 · 2 comments

Comments

@picbeats
Copy link

pinned requests conflicts with jupyterlab-server

  • jupyterlab-server==2.19.0
  • requests [required: >=2.28, installed: 2.25.1]
    or
  • pasqal-sdk==0.1.6
  • requests [required: ==2.25.1, installed: 2.28.2]

Is pinning of request-mock is also required?
Is request-mock is a functional requirements or needed only for testing?

[offtopic] pulser-pasqual=0.9.0 pins pasqal-sdk=0.1.6 version, have you considered to use semantic versioning rather than pinning, so pasqal-sdk could be upgraded independently?

@MatthieuMoreau0
Copy link
Collaborator

Hello @picbeats,

Sorry for the very late reply. I'll try to answer your questions:

  • I have pushed an MR to unpin the python dependencies as you suggested, let me know if that looks good to you.
  • request-mock has been moved to dev dependencies in a previous MR as it is only required for tests. I assume I can keep that version pinned as you will not install it to use the pasqal_cloud SDK.
  • We are indeed moving towards semantic versioning which should make the package upgrades less painful ( Follow the Semantic Version 2.0.0 specification #73)

Let me know if you have other questions!

@MatthieuMoreau0
Copy link
Collaborator

Issue should be resolved, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants