Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow the Semantic Version 2.0.0 specification #73

Open
HGSilveri opened this issue Apr 7, 2023 · 2 comments
Open

Follow the Semantic Version 2.0.0 specification #73

HGSilveri opened this issue Apr 7, 2023 · 2 comments

Comments

@HGSilveri
Copy link
Contributor

Now that other libraries (e.g. pulser-pasqal) depend on the cloud-sdk, it would be great if the versioning could start following the Semantic Versioning 2.0.0 specifcation to avoid strictly pinning the cloud-sdk version in the dependencies (I see this has already been suggested in #58).

Actually, I was under the impression that this was already the case, so the last update to pulser-pasqal changed the cloud-sdk requirement to be ~=0.1.12.

However, it seems that some breaking changes were introduced since then and v0.1.15 (the latest release at the time of writing). In particular, it seems that Endpoints() no longer accepts an account keyword argument, which is causing some of our tests to fail:

    @pytest.fixture
    def fixt():
        with patch("sdk.SDK", autospec=True) as mock_cloud_sdk_class:
            pasqal_cloud_kwargs = dict(
                username="abc",
                ***,
                group_id="ghi",
>               endpoints=Endpoints(core="core_url", account="account_url"),
                webhook="xyz",
            )
E           TypeError: __init__() got an unexpected keyword argument 'account'

I'm wondering, is there something that's preventing you from increasing MINOR instead of PATCH that I don't know about?

@MatthieuMoreau0
Copy link
Collaborator

Hey @HGSilveri sorry for the inconvenience definitely an oversight on our part, we'll be more careful in the upcoming releases. For now I'd suggest pinning strictly to the version compatible with your usage and unpinning it whenever you have made the changes to match our new API. You can refer to the changelog for the list of changes.

We'll focus on backwards compatibility for the upcoming releases!

@HGSilveri
Copy link
Contributor Author

No worries @MatthieuMoreau0 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants