[PACK] Rename cloud SDK package name when importing (#344) #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mildophin
requested review from
penguinoneshaw,
MatthieuMoreau0,
awennersteen and
Augustinio
Hey @Mildophin! You can't actually rename the PyPI registry, a new one under Nonetheless, here are is a template with a few steps you can follow to mitigate the impact of this change: https://github.com/simonw/pypi-rename |
Mildophin
changed the title
Mildophin
commented
Apr 12, 2023
Mildophin
force-pushed
the
mv/rename-sdk-import
branch
from
ca7bb39
to
eef2ca4
Compare
Mildophin
force-pushed
the
mv/rename-sdk-import
branch
2 times, most recently
from
6844e74
to
7b0ef16
Compare
Mildophin
force-pushed
the
mv/rename-sdk-import
branch
2 times, most recently
from
93447db
to
9a6af0e
Compare
Augustinio
reviewed
Apr 19, 2023
|
As it is backward compatible if we follow the rules it seems fine to declare it as a patch and actually as your previous commit is a breaking change, the 0.2.1 makes sense for my MR |
Mildophin
force-pushed
the
mv/rename-sdk-import
branch
from
9a6af0e
to
ad7ac55
Compare
MatthieuMoreau0
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if you have an idea about how to change the lib name on pypi !