Pc 31774 use atomic in bo #14083
Merged
Pc 31774 use atomic in bo #14083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroullier-pass
force-pushed
the
PC-31774-use-atomic-in-BO
branch
2 times, most recently
from
6b1e1c3
to
4c61324
Compare
Meewan
reviewed
Sep 20, 2024
Meewan
reviewed
Sep 20, 2024
| @@ -263,7 +267,7 @@ def create_offerer() -> utils.BackofficeResponse: | |||
| venue = offerers_api.create_venue(venue_creation_info, current_user) | |||
| offerers_api.create_venue_registration(venue.id, new_onboarding_info.target, new_onboarding_info.webPresence) | |||
|
|
|||
| transactional_mails.send_welcome_to_pro_email(pro_user, venue) | |||
| on_commit(partial(transactional_mails.send_welcome_to_pro_email, pro_user, venue)) | |||
There was a problem hiding this comment.
Dans cette fonction on a cette pile d'appel create_venue > get_or_create_address qui contient un rollback
pass-culture-main/api/src/pcapi/core/offerers/api.py:2630
idem pour la fonction get_or_create_offerer_address
pass-culture-main/api/src/pcapi/core/offerers/api.py:2671
vroullier-pass
force-pushed
the
PC-31774-use-atomic-in-BO
branch
2 times, most recently
from
e2953a1
to
c0cfcda
Compare
Meewan
reviewed
Oct 4, 2024
api/src/pcapi/core/offerers/api.py
Outdated
Comment on lines
2720
to
2829
| if is_managed_transaction(): | ||
| mark_transaction_as_invalid() |
There was a problem hiding this comment.
Je crain que ça empeche de créer un offerer si l'adresse existe deja.
Une solution serait re rajouter un context manager atomic autour du try except
api/src/pcapi/core/offerers/api.py
Outdated
Comment on lines
2676
to
2785
| if is_managed_transaction(): | ||
| mark_transaction_as_invalid() |
There was a problem hiding this comment.
Je crain que ça empeche de créer un offerer si l'adresse existe deja.
Une solution serait re rajouter un context manager atomic autour du try except
Meewan
force-pushed
the
PC-31774-use-atomic-in-BO
branch
7 times, most recently
from
83907d5
to
05f6907
Compare
Meewan
force-pushed
the
PC-31774-use-atomic-in-BO
branch
from
05f6907
to
afd1917
Compare
dnguyen1-pass
approved these changes
Nov 6, 2024
rpaoloni-pass
force-pushed
the
PC-31774-use-atomic-in-BO
branch
2 times, most recently
from
d5e2347
to
14045b8
Compare
rpaoloni-pass
force-pushed
the
PC-31774-use-atomic-in-BO
branch
from
14045b8
to
4ad66d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31774
Vérifications