(PC-32853)[API] feat: fix booking comparison date #14916
+82
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have yourself a merry little break and learn a few facts about the year 452. |
AleksDPass
force-pushed
the
anougbele-pass/PC-32853-virtual-offer-in-check-booking-limit-datetime
branch
from
c4b6efb
to
597fd82
Compare
| ], | ||
| ) | ||
| def test_check_booking_limit_datetime_should_raise_because_booking_limit_is_one_hour_after( | ||
| self, stock_factory_function, offer_factory_function, venue_factory_fonction |
There was a problem hiding this comment.
Suggested change
| self, stock_factory_function, offer_factory_function, venue_factory_fonction | |
| self, stock_factory, offer_factory, venue_factory |
Pas besoin de préciser le _function, l'absence de majuscule me semble suffisante.
Je ferai bien même:
Suggested change
| self, stock_factory_function, offer_factory_function, venue_factory_fonction | |
| self, StockFactory, OfferFactory, VenueFactory |
mais ça va surement faire raler pylint/mypy.
| "offer.venue.timezone", | ||
| ], | ||
| ) | ||
| def test_check_booking_limit_datetime_priorisation_order(self, case): |
There was a problem hiding this comment.
case étant un mot clef (switch/case), j'opterai bien pour un nom différent.
pour des questions de lisibilité, plutot que de décrire le cas de test, je mettrai bien directement les variables:
OffererAddressFactoryouNonepour la factory"Indian/Reunion"/ ` "America/Guadeloupe" / ZoneInfo("Europe/Paris") pour la TZ attendue
There was a problem hiding this comment.
j'ai pourtant voulu être clair. C'est raté
| beginning_date = datetime.datetime(2024, 7, 19, 8, tzinfo=datetime.timezone.utc) | ||
| booking_limit_date = beginning_date - datetime.timedelta(hours=1) | ||
| if case == "offer.offerer_address.address.timezone": | ||
| booking_limit_date = beginning_date - datetime.timedelta(hours=1) |
There was a problem hiding this comment.
Je ne suis pas certain de comprende pourquoi on doit décaler booking_limit_date
AleksDPass
force-pushed
the
anougbele-pass/PC-32853-virtual-offer-in-check-booking-limit-datetime
branch
from
597fd82
to
cb4500f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Fix [POST] /stock/bulk
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-32853
lien vers le bug sentry https://sentry.passculture.team/organizations/sentry/issues/1622746/?project=5&referrer=slack
Vérifications