(BSR)[API] feat: public api: apply atomic to event routes

api/src/pcapi/core/bookings/api.py

@@ -588,7 +588,11 @@ def _execute_cancel_booking(
             stock.dnBookedQuantity -= booking.quantity
             if booking.activationCode and stock.quantity:
                 stock.quantity -= 1
-            repository.save(booking, stock)
+
+            if is_managed_transaction():
+                db.session.flush()
+            else:
+                repository.save(booking, stock)
     return True
 
 

api/src/pcapi/core/offers/api.py

@@ -415,14 +415,16 @@ def update_offer(
 
     logger.info("Offer has been updated", extra={"offer_id": offer.id}, technical_message_id="offer.updated")
 
+    db.session.flush()
+
     withdrawal_fields = {"bookingContact", "withdrawalDelay", "withdrawalDetails", "withdrawalType"}
     withdrawal_updated = updates_set & withdrawal_fields
     oa_updated = "offererAddress" in updates
     if should_send_mail and (withdrawal_updated or oa_updated):
-        transactional_mails.send_email_for_each_ongoing_booking(offer)
+        on_commit(partial(transactional_mails.send_email_for_each_ongoing_booking, offer))
 
     reason = search.IndexationReason.OFFER_UPDATE
-    search.async_index_offer_ids([offer.id], reason=reason, log_extra={"changes": updates_set})
+    on_commit(partial(search.async_index_offer_ids, [offer.id], reason=reason, log_extra={"changes": updates_set}))
 
     return offer
 
@@ -737,9 +739,13 @@ def create_stock(
         offer.lastValidationPrice = price
     repository.add_to_session(created_stock, *created_activation_codes, offer)
     db.session.flush()
-    search.async_index_offer_ids(
-        [offer.id],
-        reason=search.IndexationReason.STOCK_CREATION,
+
+    on_commit(
+        partial(
+            search.async_index_offer_ids,
+            [offer.id],
+            reason=search.IndexationReason.STOCK_CREATION,
+        )
     )
 
     return created_stock
@@ -888,10 +894,15 @@ def publish_offer(
     else:
         if offer.publicationDate:
             offers_repository.delete_future_offer(offer.id)
-        search.async_index_offer_ids(
-            [offer.id],
-            reason=search.IndexationReason.OFFER_PUBLICATION,
+
+        on_commit(
+            partial(
+                search.async_index_offer_ids,
+                [offer.id],
+                reason=search.IndexationReason.OFFER_PUBLICATION,
+            )
         )
+
         logger.info(
             "Offer has been published",
             extra={"offer_id": offer.id, "venue_id": offer.venueId, "offer_status": offer.status},
@@ -925,7 +936,12 @@ def update_offer_fraud_information(offer: AnyOffer, user: users_models.User | No
         and not venue_already_has_validated_offer
         and isinstance(offer, models.Offer)
     ):
-        transactional_mails.send_first_venue_approved_offer_email_to_pro(offer)
+        on_commit(
+            partial(
+                transactional_mails.send_first_venue_approved_offer_email_to_pro,
+                offer,
+            )
+        )
 
 
 def _invalidate_bookings(bookings: list[bookings_models.Booking]) -> list[bookings_models.Booking]:
@@ -948,13 +964,24 @@ def _delete_stock(stock: models.Stock, author_id: int | None = None, user_connec
     )
     if cancelled_bookings:
         for booking in cancelled_bookings:
-            transactional_mails.send_booking_cancellation_by_pro_to_beneficiary_email(booking)
-        transactional_mails.send_booking_cancellation_confirmation_by_pro_email(cancelled_bookings)
+            on_commit(partial(transactional_mails.send_booking_cancellation_by_pro_to_beneficiary_email, booking))
+
+        on_commit(partial(transactional_mails.send_booking_cancellation_confirmation_by_pro_email, cancelled_bookings))
+
         if not FeatureToggle.WIP_DISABLE_CANCEL_BOOKING_NOTIFICATION.is_active():
-            push_notification_job.send_cancel_booking_notification.delay([booking.id for booking in cancelled_bookings])
-    search.async_index_offer_ids(
-        [stock.offerId],
-        reason=search.IndexationReason.STOCK_DELETION,
+            on_commit(
+                partial(
+                    push_notification_job.send_cancel_booking_notification.delay,
+                    [booking.id for booking in cancelled_bookings],
+                )
+            )
+
+    on_commit(
+        partial(
+            search.async_index_offer_ids,
+            [stock.offerId],
+            reason=search.IndexationReason.STOCK_DELETION,
+        )
     )
 
 
@@ -1009,9 +1036,12 @@ def create_mediation(
     )
     _delete_mediations_and_thumbs(previous_mediations)
 
-    search.async_index_offer_ids(
-        [offer.id],
-        reason=search.IndexationReason.MEDIATION_CREATION,
+    on_commit(
+        partial(
+            search.async_index_offer_ids,
+            [offer.id],
+            reason=search.IndexationReason.MEDIATION_CREATION,
+        )
     )
 
     return mediation
@@ -1284,10 +1314,10 @@ def set_offer_status_based_on_fraud_criteria(offer: AnyOffer) -> models.OfferVal
         status = models.OfferValidationStatus.PENDING
         offer.flaggingValidationRules = flagging_rules
         if isinstance(offer, models.Offer):
-            compliance.update_offer_compliance_score(offer, is_primary=True)
+            on_commit(partial(compliance.update_offer_compliance_score, offer, is_primary=True))
     else:
         if isinstance(offer, models.Offer):
-            compliance.update_offer_compliance_score(offer, is_primary=False)
+            on_commit(partial(compliance.update_offer_compliance_score, offer, is_primary=False))
 
     logger.info("Computed offer validation", extra={"offer": offer.id, "status": status.value})
     return status