(BSR)[PRO] test: removes videos when test is ok #14941
Open
+18
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 846874d): https://pc-pro-testing--pr14941-scolson-bsr-pro-vide-r8qc4eaf.web.app (expires Fri, 08 Nov 2024 16:14:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
scolson-pass
force-pushed
the
scolson/bsr-pro-videos-only-on-failure
branch
from
d54679e
to
71b1f0b
Compare
| @@ -145,7 +145,7 @@ jobs: | |||
| browser: chrome | |||
| config-file: cypress/cypress.config.ts | |||
| env: TAGS="@P0" | |||
| record: ${{ github.ref == 'refs/heads/master' }} # for Cypress Cloud | |||
There was a problem hiding this comment.
Je pense que c'est plus facile de faire la modif ici.
There was a problem hiding this comment.
Attend, je n'avais pas fini. Là c'est bon. J'ai activé (puis désactivé) Cypress Cloud et un faux échec sur un run:
- On a bien 1 seule vidéo dans ce répertoire:
- Tout est complet dans Cypress Cloud et on a que la vidéo du cas qui a échoué mais le test replay tout le temps
Tu peux re-relire :)
scolson-pass
force-pushed
the
scolson/bsr-pro-videos-only-on-failure
branch
from
71b1f0b
to
0059f9b
Compare
fix fix (BSR)[PRO] test: fix
scolson-pass
force-pushed
the
scolson/bsr-pro-videos-only-on-failure
branch
from
0059f9b
to
846874d
Compare
lgerard-pass
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Supprime les vidéos lorsque les tests sont OK, ils ne seront ainsi pas uploadé dans Cypress Cloud (mais on a tout de même tout le test replay même en cas de réussite) ni dans le Google Storage
Vérifications