(PC-20049)[API] refactor: improve offer ExtraData #5028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viconnex
force-pushed
the
pc-20049-extra-data
branch
2 times, most recently
from
042ece7 to
1e02b30
Compare
Debt collector report:null null null Previous debt : 0Current debt : 0Debt decreased by 0 PointsTo get a file by file report, please run debt-collector check --changed-since="[REVISION]" |
viconnex
changed the title
viconnex
force-pushed
the
pc-20049-extra-data
branch
2 times, most recently
from
438178e to
219fb84
Compare
|
Have yourself a merry little break and learn a few facts about the year 940. |
viconnex
force-pushed
the
pc-20049-extra-data
branch
6 times, most recently
from
c57b180 to
e96036d
Compare
viconnex
changed the title
lixxday
approved these changes
Jan 25, 2023
Comment on lines
+171
to
+172
| if not self.product_subcategory_id: | ||
| raise ValueError("product subcategory id is missing") |
There was a problem hiding this comment.
C'est un bug fix en plus dans ce commit ?
There was a problem hiding this comment.
Non c'est plutôt une question de typage : une erreur mypy est apparue (parce qu'il y a moins de Any ?). Pour enlever cette erreur mypy, on raise une erreur de manière explicite (de toute façon on aurait eu une KeyError dans ce cas)
cepehang
reviewed
Jan 25, 2023
viconnex
force-pushed
the
pc-20049-extra-data
branch
from
e96036d to
e6d8e62
Compare
dbaty
approved these changes
Jan 25, 2023
api/src/pcapi/routes/serialization/collective_bookings_serialize.py
Outdated
Show resolved
Hide resolved
it does not seem to be reusable. when reused, mypy raises an error because the infered type is the type of the first(?) column variable that uses it
viconnex
force-pushed
the
pc-20049-extra-data
branch
from
e6d8e62 to
7b691dd
Compare
this property is neither filled nor present in staging database
viconnex
force-pushed
the
pc-20049-extra-data
branch
from
7b691dd to
b094f99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lien vers le ticket Jira : https://passculture.atlassian.net/browse/PC-20049
Limitations
Malheureusement on ne peut pas :
extra_data.get("diffusionVersion", "")eststr | Noneoffers_models.Product.extraData["isbnz"].astext)