Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: jwt audience validation #89

Merged
merged 13 commits into from
Dec 10, 2024
Merged

feat: jwt audience validation #89

merged 13 commits into from
Dec 10, 2024

Conversation

tdeshong
Copy link
Contributor

What's New?

Add validation for jwt audience.

  • checks if audience exists
  • checks that audience is the app id (similar to the python sdk)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tdeshong tdeshong requested review from ctran88 and bertrmz October 18, 2024 14:56
go.mod Outdated Show resolved Hide resolved
authentication.go Outdated Show resolved Hide resolved
authentication.go Outdated Show resolved Hide resolved
@tdeshong tdeshong marked this pull request as draft October 18, 2024 16:33
Copy link

@tdeshong tdeshong marked this pull request as ready for review October 18, 2024 17:05
@tdeshong tdeshong marked this pull request as draft October 29, 2024 18:49
@tdeshong tdeshong changed the title PSG-4625 validate jwt audience feat: jwt audience validation Dec 2, 2024
@tdeshong tdeshong marked this pull request as ready for review December 2, 2024 19:55
@tdeshong tdeshong requested a review from ctran88 December 2, 2024 19:55
authentication.go Outdated Show resolved Hide resolved
@tdeshong tdeshong requested a review from ctran88 December 3, 2024 21:16
authentication.go Outdated Show resolved Hide resolved
auth.go Outdated Show resolved Hide resolved
@tdeshong tdeshong merged commit ae2f00d into main Dec 10, 2024
6 checks passed
@tdeshong tdeshong deleted the PSG-4625-validate-jwt-aud branch December 10, 2024 20:38
This was referenced Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants